Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 315763003: Update background color when it is transparent. (Closed)

Created:
6 years, 6 months ago by hush (inactive)
Modified:
6 years, 6 months ago
CC:
blink-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

backgroundColor with 0 alpha is still valid, and FrameView should set the color. For example, android can set the background color of a WebView to be transparent. This sets the mainframe base background color to be transparent. The internal bug is b/15373310 BUG=375864 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175586

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M Source/core/frame/LocalFrame.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 4 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
hush (inactive)
ptal
6 years, 6 months ago (2014-06-03 21:05:18 UTC) #1
aelias_OOO_until_Jul13
Could you also add a unit test case for this?
6 years, 6 months ago (2014-06-03 21:08:56 UTC) #2
hush (inactive)
On 2014/06/03 21:08:56, aelias wrote: > Could you also add a unit test case for ...
6 years, 6 months ago (2014-06-03 21:25:10 UTC) #3
Timothy Loh
On 2014/06/03 21:25:10, hush wrote: > On 2014/06/03 21:08:56, aelias wrote: > > Could you ...
6 years, 6 months ago (2014-06-04 08:41:31 UTC) #4
hush (inactive)
Hi! Test is added. Please take a look!
6 years, 6 months ago (2014-06-04 23:29:03 UTC) #5
aelias_OOO_until_Jul13
lgtm, still needs Source/core OWNERS though.
6 years, 6 months ago (2014-06-05 16:55:09 UTC) #6
Timothy Loh
On 2014/06/05 16:55:09, aelias wrote: > lgtm, still needs Source/core OWNERS though. Source/core lgtm
6 years, 6 months ago (2014-06-05 17:06:36 UTC) #7
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 6 months ago (2014-06-05 17:10:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/315763003/20001
6 years, 6 months ago (2014-06-05 17:11:03 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 18:14:30 UTC) #10
Message was sent while issue was closed.
Change committed as 175586

Powered by Google App Engine
This is Rietveld 408576698