Source/web/tests/WebViewTest.cpp - Issue 315763003: Update background color when it is transparent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebViewTest.cpp

Issue 315763003: Update background color when it is transparent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebViewTest.cpp

diff --git a/Source/web/tests/WebViewTest.cpp b/Source/web/tests/WebViewTest.cpp

index 48c723b08c0c27cbe463173405bade557825a1cc..e18e7ac52264779e7eb95c31326cc494d5030c05 100644

--- a/Source/web/tests/WebViewTest.cpp

+++ b/Source/web/tests/WebViewTest.cpp

@@ -34,6 +34,7 @@

#include "core/dom/Document.h"

#include "core/dom/Element.h"

#include "core/frame/FrameView.h"

+#include "core/frame/LocalFrame.h"

#include "core/frame/Settings.h"

#include "core/html/HTMLDocument.h"

#include "core/html/HTMLIFrameElement.h"

@@ -44,6 +45,7 @@

#include "core/rendering/RenderLayer.h"

#include "core/rendering/RenderView.h"

#include "platform/KeyboardCodes.h"

+#include "platform/geometry/IntSize.h"

#include "platform/graphics/Color.h"

#include "public/platform/Platform.h"

#include "public/platform/WebDragData.h"

@@ -217,8 +219,9 @@ TEST_F(WebViewTest, SetBaseBackgroundColor)

const WebColor kBlue = 0xFF0000FF;

const WebColor kDarkCyan = 0xFF227788;

const WebColor kTranslucentPutty = 0x80BFB196;

+ const WebColor kTransparent = 0x00000000;

- WebView* webView = m_webViewHelper.initialize();

+ WebViewImpl* webView = m_webViewHelper.initialize();

EXPECT_EQ(kWhite, webView->backgroundColor());

webView->setBaseBackgroundColor(kBlue);

@@ -235,6 +238,21 @@ TEST_F(WebViewTest, SetBaseBackgroundColor)

webView->setBaseBackgroundColor(kTranslucentPutty);

// Expected: red (50% alpha) blended atop kTranslucentPutty. Note the alpha.

EXPECT_EQ(0xBFE93B32, webView->backgroundColor());

+ webView->setBaseBackgroundColor(kTransparent);

+ FrameTestHelpers::loadHTMLString(webView->mainFrame(), "<html><head><style>body {background-color:transparent}</style></head></html>", baseURL);

+ // Expected: transparent on top of kTransparent will still be transparent.

+ EXPECT_EQ(kTransparent, webView->backgroundColor());

+ WebCore::LocalFrame* frame = webView->mainFrameImpl()->frame();

+ // Creating a new frame view with the background color having 0 alpha.

+ frame->createView(WebCore::IntSize(1024, 768), WebCore::Color::transparent, true);

+ EXPECT_EQ(kTransparent, frame->view()->baseBackgroundColor());

+ WebCore::Color kTransparentRed(100, 0, 0, 0);

+ frame->createView(WebCore::IntSize(1024, 768), kTransparentRed, true);

+ EXPECT_EQ(kTransparentRed, frame->view()->baseBackgroundColor());

}

TEST_F(WebViewTest, SetBaseBackgroundColorBeforeMainFrame)

« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | no next file » | no next file with comments »