Issue 315753003: Pepper: Miscellaneous trusted plugin cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315753003: Pepper: Miscellaneous trusted plugin cleanup. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Miscellaneous trusted plugin cleanup. This removes some more unnecessary methods and moves some more UMA reporting out of the trusted plugin, reducing the total line count. It's a little awkward that we have to pass the max value of NaClErrorCode to the new reporting method, but it keeps that enum out of the public NaCl interface. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274898

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -121 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	8 chunks	+20 lines, -22 lines	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	4 chunks	+9 lines, -8 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	5 chunks	+9 lines, -7 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View	6 chunks	+12 lines, -54 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	6 chunks	+10 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

teravest

6 years, 6 months ago (2014-06-04 20:29:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r274898 (presubmit successful).

Expand Messages | Collapse Messages