Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/service_runtime.cc

Issue 315753003: Pepper: Miscellaneous trusted plugin cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 * Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime" 7 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime"
8 8
9 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h" 9 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h"
10 10
(...skipping 556 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 ErrorInfo error_info; 567 ErrorInfo error_info;
568 error_info.SetReport(PP_NACL_ERROR_SEL_LDR_START_MODULE, 568 error_info.SetReport(PP_NACL_ERROR_SEL_LDR_START_MODULE,
569 "ServiceRuntime: could not start nacl module"); 569 "ServiceRuntime: could not start nacl module");
570 plugin_->ReportLoadError(error_info); 570 plugin_->ReportLoadError(error_info);
571 } 571 }
572 return false; 572 return false;
573 } 573 }
574 } 574 }
575 575
576 NaClLog(4, "ServiceRuntime::StartModule (load_status=%d)\n", load_status); 576 NaClLog(4, "ServiceRuntime::StartModule (load_status=%d)\n", load_status);
577 if (main_service_runtime_) 577 if (main_service_runtime_) {
578 plugin_->ReportSelLdrLoadStatus(load_status); 578 if (load_status < 0 || load_status > NACL_ERROR_CODE_MAX)
579 load_status = LOAD_STATUS_UNKNOWN;
580 GetNaClInterface()->ReportSelLdrStatus(plugin_->pp_instance(),
581 load_status,
582 NACL_ERROR_CODE_MAX);
583 }
579 584
580 if (LOAD_OK != load_status) { 585 if (LOAD_OK != load_status) {
581 if (main_service_runtime_) { 586 if (main_service_runtime_) {
582 ErrorInfo error_info; 587 ErrorInfo error_info;
583 error_info.SetReport( 588 error_info.SetReport(
584 PP_NACL_ERROR_SEL_LDR_START_STATUS, 589 PP_NACL_ERROR_SEL_LDR_START_STATUS,
585 NaClErrorString(static_cast<NaClErrorCode>(load_status))); 590 NaClErrorString(static_cast<NaClErrorCode>(load_status)));
586 plugin_->ReportLoadError(error_info); 591 plugin_->ReportLoadError(error_info);
587 } 592 }
588 return false; 593 return false;
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
772 777
773 nacl::string ServiceRuntime::GetCrashLogOutput() { 778 nacl::string ServiceRuntime::GetCrashLogOutput() {
774 if (NULL != subprocess_.get()) { 779 if (NULL != subprocess_.get()) {
775 return subprocess_->GetCrashLogOutput(); 780 return subprocess_->GetCrashLogOutput();
776 } else { 781 } else {
777 return std::string(); 782 return std::string();
778 } 783 }
779 } 784 }
780 785
781 } // namespace plugin 786 } // namespace plugin
OLDNEW
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/plugin.cc ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698