Issue 315743003: Use Identity matrix for SkTransparentShader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315743003: Use Identity matrix for SkTransparentShader. (Closed)

Created:
6 years, 6 months ago by scroggo

Modified:
6 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Use Identity matrix for SkTransparentShader. The SkTransparentShader is just a placeholder that should not actually be used, so its CTM is not meaningful. However, it needs to be invertible in order to not assert in SkShader::Context's constructor. So use SkMatrix::I(). This fixes a CTS test on Android. Committed: https://skia.googlesource.com/skia/+/ca76c55d60dfe041e30e210d41fa0feb7fb54a1f

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/core/SkBlitter.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/315743003/1

6 years, 6 months ago (2014-06-04 14:06:00 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-04 15:21:04 UTC) #5

Message was sent while issue was closed.

Change committed as ca76c55d60dfe041e30e210d41fa0feb7fb54a1f

Expand Messages | Collapse Messages