Source/web/FrameLoaderClientImpl.cpp - Issue 315693002: Use WebViewClient instead of BlinkPlatform for screen lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 315693002: Use WebViewClient instead of BlinkPlatform for screen lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientationController.cpp ('K') | « Source/modules/screen_orientation/ScreenOrientationController.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | public/platform/Platform.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/FrameLoaderClientImpl.cpp

diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp

index 686b8f4cdf7728c446ba95a9727fca17805c53b9..79a34152eeb7f86fe59e87e1447d4650a177b5f1 100644

--- a/Source/web/FrameLoaderClientImpl.cpp

+++ b/Source/web/FrameLoaderClientImpl.cpp

@@ -57,7 +57,6 @@

#include "modules/device_orientation/DeviceMotionController.h"

#include "modules/device_orientation/DeviceOrientationController.h"

#include "modules/gamepad/NavigatorGamepad.h"

-#include "modules/screen_orientation/ScreenOrientationController.h"

#include "modules/serviceworkers/NavigatorServiceWorker.h"

#include "platform/MIMETypeRegistry.h"

#include "platform/UserGestureIndicator.h"

@@ -125,8 +124,6 @@ void FrameLoaderClientImpl::dispatchDidClearWindowObjectInMainWorld()

DeviceOrientationController::from(*document);

if (RuntimeEnabledFeatures::deviceLightEnabled())

DeviceLightController::from(*document);

- if (RuntimeEnabledFeatures::screenOrientationEnabled())

- ScreenOrientationController::from(*document);

if (RuntimeEnabledFeatures::gamepadEnabled())

NavigatorGamepad::from(*document);

if (RuntimeEnabledFeatures::serviceWorkerEnabled())