public/platform/Platform.h - Issue 315693002: Use WebViewClient instead of BlinkPlatform for screen lock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/Platform.h

Issue 315693002: Use WebViewClient instead of BlinkPlatform for screen lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/screen_orientation/ScreenOrientationController.cpp ('K') | « Source/web/WebViewImpl.cpp ('k') | public/platform/WebScreenOrientationClient.h » ('j') | public/platform/WebScreenOrientationClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/Platform.h

diff --git a/public/platform/Platform.h b/public/platform/Platform.h

index fe4e9bbf4fc2beef0327443e768c5e0b7e93eb7a..3adc2a01aae46a52b1bb491fd53c60a876623ba8 100644

--- a/public/platform/Platform.h

+++ b/public/platform/Platform.h

@@ -643,8 +643,8 @@ public:

// Screen Orientation -------------------------------------------------

+ // FIXME: this is meant to be removed when the content layer will be updated.

- virtual void setScreenOrientationListener(blink::WebScreenOrientationListener*) { }

Inactive 2014/06/03 18:04:53 So this is no longer overridden on Chromium side?

mlamouri (slow - plz ping) 2014/06/03 19:49:30 It is. But it is no longer used. My content/ patch

virtual void lockOrientation(WebScreenOrientationLockType) { }

// Request a screen orientation lock and pass a |callback| object to be used

// to notify of success/failure. The |callback| parameter is expected to be