Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 315483002: MSE: Remove Chromium-side support for LegacyFrameProcessor (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, DaleCurtis
Visibility:
Public.

Description

MSE: Remove Chromium-side support for LegacyFrameProcessor This is the second of a three-sided change to remove LegacyFrameProcessor from Blink and Chromium now that the new FrameProcessor is stabilized. R=acolwell@chromium.org BUG=249422 TEST=No media_unittest or MSE layout test regression locally on Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278255

Patch Set 1 #

Patch Set 2 : Rebase due to https://codereview.chromium.org/278673003 #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Rebase and address comment #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -638 lines) Patch
M content/renderer/media/webmediasource_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webmediasource_impl.cc View 1 chunk +1 line, -5 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 3 4 6 chunks +9 lines, -19 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 4 97 chunks +97 lines, -129 lines 0 comments Download
D media/filters/legacy_frame_processor.h View 1 chunk +0 lines, -89 lines 0 comments Download
D media/filters/legacy_frame_processor.cc View 1 chunk +0 lines, -288 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 2 3 41 chunks +76 lines, -101 lines 0 comments Download
M media/media.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wolenetz
In anticipation of hopefully removing LegacyFrameProcessor soon: PTAL @ PS1 acolwell@: OWNERS review for everything ...
6 years, 6 months ago (2014-06-03 02:57:42 UTC) #1
wolenetz
On 2014/06/03 02:57:42, wolenetz wrote: > In anticipation of hopefully removing LegacyFrameProcessor soon: > PTAL ...
6 years, 6 months ago (2014-06-03 20:00:20 UTC) #2
wolenetz
PTAL @ PS2. I'm fine with review not beginning until next Monday (6/9/2014), to give ...
6 years, 6 months ago (2014-06-03 20:13:36 UTC) #3
wolenetz
PTAL @ PS3 (just a rebase). Intent is to land this by EOW or early ...
6 years, 6 months ago (2014-06-09 20:34:03 UTC) #4
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/315483002/diff/40001/media/filters/chunk_demuxer.cc File media/filters/chunk_demuxer.cc (right): https://codereview.chromium.org/315483002/diff/40001/media/filters/chunk_demuxer.cc#newcode1169 media/filters/chunk_demuxer.cc:1169: scoped_ptr<FrameProcessorBase> frame_processor( s/Base//?
6 years, 6 months ago (2014-06-13 18:26:42 UTC) #5
wolenetz
Thanks for review. Landing this pends first landing Blink CL https://codereview.chromium.org/310733002/ and rolling Blink DEPS ...
6 years, 6 months ago (2014-06-16 20:01:38 UTC) #6
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 6 months ago (2014-06-18 21:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/315483002/100001
6 years, 6 months ago (2014-06-18 21:11:41 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 03:20:52 UTC) #9
Message was sent while issue was closed.
Change committed as 278255

Powered by Google App Engine
This is Rietveld 408576698