Enable splice frames and partial appends for AAC; with test!

Enable splice frames and partial appends for AAC; with test!

Fingers crossed, hopefully all known bugs are fixed.

BUG=356073, 371633, 369204
TEST=new unittest.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274457

[DaleCurtis, 2014-05-08 22:43:14]

Part II!  Again, please don't worry about looking at this
until after the branch cut.  Thanks!

[acolwell GONE FROM CHROMIUM, 2014-05-16 17:04:43]

lgtm

[wolenetz, 2014-05-16 20:06:15]

lgtm % nit

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:859: // the first decoded frame to be
incorrect if preroll isn't implemented.
nit: By "preroll", do you really mean partial append window clipping?
s/preroll isn't implemented/partial (start overlap) append window clipping isn't
implemented for ADTS/?

[DaleCurtis, 2014-05-16 20:11:55]

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:859: // the first decoded frame to be
incorrect if preroll isn't implemented.
On 2014/05/16 20:06:16, wolenetz wrote:
> nit: By "preroll", do you really mean partial append window clipping?
> s/preroll isn't implemented/partial (start overlap) append window clipping
isn't
> implemented for ADTS/?

No I mean preroll as in this won't work if partial append window trimming +
preroll on that append is enabled.

[wolenetz, 2014-05-16 20:17:32]

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
File media/filters/pipeline_integration_test.cc (right):

https://codereview.chromium.org/278673003/diff/1/media/filters/pipeline_integ...
media/filters/pipeline_integration_test.cc:859: // the first decoded frame to be
incorrect if preroll isn't implemented.
On 2014/05/16 20:11:56, DaleCurtis wrote:
> On 2014/05/16 20:06:16, wolenetz wrote:
> > nit: By "preroll", do you really mean partial append window clipping?
> > s/preroll isn't implemented/partial (start overlap) append window clipping
> isn't
> > implemented for ADTS/?
> 
> No I mean preroll as in this won't work if partial append window trimming +
> preroll on that append is enabled.

I understand and lgtm if you meant "this test will fail if partial append window
trimming + preroll on that append is *NOT* enabled)"

[DaleCurtis, 2014-06-02 23:06:01]

Sending to the CQ.  Thanks for review guys!

[DaleCurtis, 2014-06-02 23:06:06]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2014-06-02 23:06:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/278673003/40001

[commit-bot: I haz the power, 2014-06-03 03:08:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-03 10:28:19]

Change committed as 274457