Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

Issue 315413004: Remove param |context_type| from InitOriginPermissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
diff --git a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
index ef6a60f11f5e8f75e96e9fafaba212fc0c3be5c9..dc7f511748f31d3f01605240695093a2833e145d 100644
--- a/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
+++ b/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
@@ -69,13 +69,11 @@ ChromeExtensionsDispatcherDelegate::CreateScriptContext(
}
void ChromeExtensionsDispatcherDelegate::InitOriginPermissions(
- const extensions::Extension* extension,
- extensions::Feature::Context context_type) {
+ const extensions::Extension* extension) {
// TODO(jstritar): We should try to remove this special case. Also, these
// whitelist entries need to be updated when the kManagement permission
// changes.
- if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT &&
- extension->HasAPIPermission(extensions::APIPermission::kManagement)) {
+ if (extension->HasAPIPermission(extensions::APIPermission::kManagement)) {
not at google - send to devlin 2014/06/06 18:55:19 I'm not confident that removing the context check
blink::WebSecurityPolicy::addOriginAccessWhitelistEntry(
extension->url(),
blink::WebString::fromUTF8(content::kChromeUIScheme),
« no previous file with comments | « chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h ('k') | extensions/renderer/dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698