Remove param |context_type| from InitOriginPermissions

chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
 
 #include "base/command_line.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 51 matching lines @@
 ChromeExtensionsDispatcherDelegate::CreateScriptContext(
     const v8::Handle<v8::Context>& v8_context,
     blink::WebFrame* frame,
     const extensions::Extension* extension,
     extensions::Feature::Context context_type) {
   return scoped_ptr<extensions::ScriptContext>(new extensions::ChromeV8Context(
       v8_context, frame, extension, context_type));
 }
 
 void ChromeExtensionsDispatcherDelegate::InitOriginPermissions(
-    const extensions::Extension* extension,
-    extensions::Feature::Context context_type) {
+    const extensions::Extension* extension) {
   // TODO(jstritar): We should try to remove this special case. Also, these
   // whitelist entries need to be updated when the kManagement permission
   // changes.
-  if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT &&
-      extension->HasAPIPermission(extensions::APIPermission::kManagement)) {
+  if (extension->HasAPIPermission(extensions::APIPermission::kManagement)) {

[not at google - send to devlin, 2014/06/06 18:55:19]

I'm not confident that removing the context check here is a no-op.
InitOriginPermissions is called from content scripts too, and we don't want
content scripts getting access to chrome:// URLs just because they have the
management permission (which is a hack in the first place anyway).

a couple of ways to fix this:
- pass the Dispatcher into this method and check
dispatcher->IsExtensionActive(extension->id())
- just pass in a bool whether the extension is active

whichever is easier for you.

     blink::WebSecurityPolicy::addOriginAccessWhitelistEntry(
         extension->url(),
         blink::WebString::fromUTF8(content::kChromeUIScheme),
         blink::WebString::fromUTF8(chrome::kChromeUIExtensionIconHost),
         false);
   }
 }
 
 void ChromeExtensionsDispatcherDelegate::RegisterNativeHandlers(
     extensions::Dispatcher* dispatcher,
@@ skipping 281 matching lines @@
 }
 
 void ChromeExtensionsDispatcherDelegate::HandleWebRequestAPIUsage(
     bool adblock,
     bool adblock_plus,
     bool other) {
   webrequest_adblock_ = adblock;
   webrequest_adblock_plus_ = adblock_plus;
   webrequest_other_ = other;
 }