Remove param |context_type| from InitOriginPermissions

Remove param |context_type| from InitOriginPermissions

This CL is to prepare for https://codereview.chromium.org/315143003 .

This param |context_type| was added in https://codereview.chromium.org/169053005 ,
but its only usage in |ChromeExtensionsDispatcherDelegate::InitOriginPermissions|
seems unnecesary. The reason is that |WebSecurityPolicy::addOriginAccessWhitelistEntry|
operates on the global whitelist map valid for all context within
the renderer process.

BUG=380346, 380502
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276101

[kouhei (in TOK), 2014-06-06 04:41:19]

kalman, mpcomplete: Would you take a look?

[not at google - send to devlin, 2014-06-06 18:55:19]

thanks for making this change.

https://codereview.chromium.org/315413004/diff/1/chrome/renderer/extensions/c...
File chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc
(right):

https://codereview.chromium.org/315413004/diff/1/chrome/renderer/extensions/c...
chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc:76: if
(extension->HasAPIPermission(extensions::APIPermission::kManagement)) {
I'm not confident that removing the context check here is a no-op.
InitOriginPermissions is called from content scripts too, and we don't want
content scripts getting access to chrome:// URLs just because they have the
management permission (which is a hack in the first place anyway).

a couple of ways to fix this:
- pass the Dispatcher into this method and check
dispatcher->IsExtensionActive(extension->id())
- just pass in a bool whether the extension is active

whichever is easier for you.

[Matt Perry, 2014-06-06 20:26:58]

lgtm with kalman's suggestion

[kouhei (in TOK), 2014-06-09 04:42:27]

PTAL

> - just pass in a bool whether the extension is active
Done.

[not at google - send to devlin, 2014-06-09 17:12:51]

lgtm

[kouhei (in TOK), 2014-06-10 00:56:00]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-06-10 00:57:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/315413004/20001

[commit-bot: I haz the power, 2014-06-10 14:18:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-10 14:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 14:42:10]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[kouhei (in TOK), 2014-06-10 15:31:09]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-06-10 15:33:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/315413004/20001

[commit-bot: I haz the power, 2014-06-10 16:01:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-10 18:46:10]

Change committed as 276101