Issue 315403006: Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to …

Issue 315403006: Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.

Modified:
6 years, 6 months ago

Reviewers:
gab, rvargas (doing something else), grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher Also add them to the Windows trybots BUG=381071 R=grt@chromium.org, rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801

Patch Set 3 : trybots #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -92 lines)			Patch
M	base/test/launcher/test_launcher.h	View		3 chunks	+5 lines, -20 lines	0 comments	Download
M	base/test/launcher/test_launcher.cc	View		9 chunks	+34 lines, -38 lines	0 comments	Download
M	base/test/launcher/unit_test_launcher.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	base/test/launcher/unit_test_launcher.cc	View		8 chunks	+51 lines, -13 lines	0 comments	Download
M	base/test/test_suite.h	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	base/test/test_suite.cc	View		3 chunks	+32 lines, -11 lines	0 comments	Download
M	chrome/installer/util/run_all_unittests.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	content/public/test/test_launcher.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sandbox/win/sandbox_win.gypi	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	sandbox/win/tests/integration_tests/integration_tests.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	sandbox/win/tests/unit_tests/unit_tests.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	sandbox/win/tests/validation_tests/unit_tests.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	testing/buildbot/chromium_trybot.json	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

lgtm https://codereview.chromium.org/315403006/diff/1/base/test/launcher/unit_test_launcher.h File base/test/launcher/unit_test_launcher.h (right): https://codereview.chromium.org/315403006/diff/1/base/test/launcher/unit_test_launcher.h#newcode27 base/test/launcher/unit_test_launcher.h:27: // |use_job_objects| determines whether to use job objects ...

6 years, 6 months ago (2014-06-06 18:55:39 UTC) #3

Paweł Hajdan Jr.

https://codereview.chromium.org/315403006/diff/1/base/test/launcher/unit_test_launcher.h File base/test/launcher/unit_test_launcher.h (right): https://codereview.chromium.org/315403006/diff/1/base/test/launcher/unit_test_launcher.h#newcode27 base/test/launcher/unit_test_launcher.h:27: // |use_job_objects| determines whether to use job objects on ...

6 years, 6 months ago (2014-06-09 09:08:33 UTC) #4

Paweł Hajdan Jr.

Committed patchset #3 manually as r275801 (presubmit successful).

6 years, 6 months ago (2014-06-09 13:33:39 UTC) #5

alph

6 years, 6 months ago (2014-06-09 14:43:58 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/314173005/ by alph@chromium.org.

The reason for reverting is: Broke a bunch of unit tests on Win.
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568.

Expand Messages | Collapse Messages