Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3064)

Unified Diff: base/test/launcher/test_launcher.h

Issue 315403006: Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: trybots Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/launcher/test_launcher.h
diff --git a/base/test/launcher/test_launcher.h b/base/test/launcher/test_launcher.h
index ec0b2c15a1c0fccf628468895e169b52f0b2196d..600c4dec339f3fee2c83c591abd6212891f8490b 100644
--- a/base/test/launcher/test_launcher.h
+++ b/base/test/launcher/test_launcher.h
@@ -75,7 +75,7 @@ class TestLauncher {
~TestLauncher();
// Runs the launcher. Must be called at most once.
- bool Run(int argc, char** argv) WARN_UNUSED_RESULT;
+ bool Run() WARN_UNUSED_RESULT;
// Callback called after a child process finishes. First argument is the exit
// code, second one is child process elapsed time, third one is true if
@@ -87,11 +87,13 @@ class TestLauncher {
// Launches a child process (assumed to be gtest-based binary) using
// |command_line|. If |wrapper| is not empty, it is prepended to the final
// command line. If the child process is still running after |timeout|, it
- // is terminated. After the child process finishes |callback| is called
- // on the same thread this method was called.
+ // is terminated. |use_job_objects| determines whether job objects are used
+ // on Windows (if unsure pass true). After the child process finishes
+ // |callback| is called on the same thread this method was called.
void LaunchChildGTestProcess(const CommandLine& command_line,
const std::string& wrapper,
base::TimeDelta timeout,
+ bool use_job_objects,
const LaunchChildGTestProcessCallback& callback);
// Called when a test has finished running.
@@ -184,28 +186,11 @@ class TestLauncher {
std::string GetTestOutputSnippet(const TestResult& result,
const std::string& full_output);
-// Launches a child process (assumed to be gtest-based binary)
-// using |command_line|. If |wrapper| is not empty, it is prepended
-// to the final command line. If the child process is still running
-// after |timeout|, it is terminated and |*was_timeout| is set to true.
-int LaunchChildGTestProcess(const CommandLine& command_line,
- const std::string& wrapper,
- base::TimeDelta timeout,
- bool* was_timeout);
-
// Returns command line command line after gtest-specific processing
// and applying |wrapper|.
CommandLine PrepareCommandLineForGTest(const CommandLine& command_line,
const std::string& wrapper);
-// Launches a child process using |command_line|. If the child process is still
-// running after |timeout|, it is terminated and |*was_timeout| is set to true.
-// Returns exit code of the process.
-int LaunchChildTestProcessWithOptions(const CommandLine& command_line,
- const LaunchOptions& options,
- base::TimeDelta timeout,
- bool* was_timeout);
-
} // namespace base
#endif // BASE_TEST_LAUNCHER_TEST_LAUNCHER_H_
« no previous file with comments | « no previous file | base/test/launcher/test_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698