Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: build/common.gypi

Issue 315323002: Disable Warning 4702 for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update the comment. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5a2753f08af3172e7c9d25e2efb04e6479d74aad..fe22c66aa14abb0b2cec5e4f9028859afd5717fe 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4967,6 +4967,14 @@
},
],
['optimize=="max"', {
+ # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
+ # builds. Probably anything that this would catch that
+ # wouldn't be caught in a normal build isn't going to
+ # actually be a bug, so the incremental value of C4702 for
+ # PGO builds is likely very small.
+ 'msvs_disabled_warnings': [
+ 4702
bradn 2014/06/10 16:42:47 Could you not introduce a define here to allow the
Sébastien Marchand 2014/06/10 17:03:33 I could do this, but maintaining a list of these w
+ ],
'msvs_settings': {
'VCCLCompilerTool': {
# 2, optimizeMaxSpeed, Maximize Speed (/O2)

Powered by Google App Engine
This is Rietveld 408576698