Disable Warning 4702 for the PGO builds.

components/nacl/loader/nacl_listener.cc

Index: components/nacl/loader/nacl_listener.cc
diff --git a/components/nacl/loader/nacl_listener.cc b/components/nacl/loader/nacl_listener.cc
index 9aa210f5bb8bceae6d7cf84f652df09f8835ebb9..406b33dcf46ce700ffc0d9dd350ac61f913a8738 100644
--- a/components/nacl/loader/nacl_listener.cc
+++ b/components/nacl/loader/nacl_listener.cc
@@ -476,5 +476,4 @@ void NaClListener::OnStart(const nacl::NaClStartParams& params) {
 #endif
 
   NaClChromeMainStartApp(nap, args);

[bradn, 2014/06/10 16:42:47]

I'm a little uncomfortable with this being removed.
Could we not introduce a define and do this conditionally?

[Sébastien Marchand, 2014/06/10 17:03:33]

I could do this but the NaCLChromeMainStartApp function doesn't return and this
cause an 'unreachable code' warning to be triggered... 

[bradn, 2014/06/10 17:35:31]

So we have this here for a very particular reason.
This is very much an assert. We're setting up nacl at this point, potentially
doing non-intuitive things and want to be certain that control flow does not get
beyond here.

As you're also disabling the unreachable code warning in this change, why is
this any issue anyhow?

[Sébastien Marchand, 2014/06/10 17:40:49]

I've address Peter's comment her
https://code.google.com/p/chromium/issues/detail?id=380175#c29 ("We should kill
this particular NOTREACHED() regardless -- it's legitimately unreachable and
shouldn't be in the codebase"), but if you feel that there's a strong reason for
it to be there then I could restore it... It's just that it might potentially
break the official build one day (as the 'unreachable code' warning isn't turned
off on it, so the compiler might realize that this code can't be reached...)

-  NOTREACHED();
 }