Enable Oilpan by default in modules/speech/

Source/web/WebSpeechGrammar.cpp

Index: Source/web/WebSpeechGrammar.cpp
diff --git a/Source/web/WebSpeechGrammar.cpp b/Source/web/WebSpeechGrammar.cpp
index 3d95263f959ccfa1a24d607268e5be2323a71974..3397d4fd64b44000c68145928ba95b0dd33a83d0 100644
--- a/Source/web/WebSpeechGrammar.cpp
+++ b/Source/web/WebSpeechGrammar.cpp
@@ -41,14 +41,14 @@ void WebSpeechGrammar::assign(const WebSpeechGrammar& other)
     m_private = other.m_private;
 }
 
-WebSpeechGrammar::WebSpeechGrammar(const PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)
-    : m_private(value)
+WebSpeechGrammar::WebSpeechGrammar(const WebCore::SpeechGrammar* value)

[tkent, 2014/06/09 01:28:46]

This is not a mechanical change.  The argument type should be
|WebCore::SpeechGrammer*| or |WebCore::SpeechGrammer* const|.

|const PassRefPtrWillBeRawPtr<T>| means PassRefPtrWIllBeRawPtr is const.  |const
T*| means T is const.

[sof, 2014/06/09 12:24:32]

This is a good issue to bring up as we remove transition types & let go of
(smart) pointer wrapper types. We need to come to some agreement of what the
conversion constructors and copy assignment operator should take as arguments.

The use of 'const' previously served the purpose of not allowing the wrapper
object to be modified by these operators+constructors. We don't have those
wrappers any longer to contend with here.

I think the conversion constructor should now have the type as given here. The
use&placement of const isn't arbitrary - i.e., it should not be allowed to
modify the argument's value lest there is a good reason for allowing such. Your
suggestion either allows arbitrary modification of the pointed-to value, or
simply prevent modification of the pointer value (but not its contents.) Could
you explain the motivation for preferring either of those two?

[tkent, 2014/06/10 03:19:14]

I understand your point.  But it's not the topic of this CL.
WebFoo wrapper classes have function members which update the corresponding core
classes.  So passing |const Foo*| is not practical.

+    : m_private(const_cast<WebCore::SpeechGrammar*>(value))
 {
 }
 
-WebSpeechGrammar& WebSpeechGrammar::operator=(const PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)
+WebSpeechGrammar& WebSpeechGrammar::operator=(const WebCore::SpeechGrammar* value)
 {
-    m_private = value;
+    m_private = const_cast<WebCore::SpeechGrammar*>(value);
     return *this;
 }