Enable Oilpan by default in modules/speech/

Source/web/WebSpeechGrammar.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 23 matching lines @@
 void WebSpeechGrammar::reset()
 {
     m_private.reset();
 }
 
 void WebSpeechGrammar::assign(const WebSpeechGrammar& other)
 {
     m_private = other.m_private;
 }
 
-WebSpeechGrammar::WebSpeechGrammar(const PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)
-    : m_private(value)
+WebSpeechGrammar::WebSpeechGrammar(const WebCore::SpeechGrammar* value)

[tkent, 2014/06/09 01:28:46]

This is not a mechanical change.  The argument type should be
|WebCore::SpeechGrammer*| or |WebCore::SpeechGrammer* const|.

|const PassRefPtrWillBeRawPtr<T>| means PassRefPtrWIllBeRawPtr is const.  |const
T*| means T is const.

[sof, 2014/06/09 12:24:32]

This is a good issue to bring up as we remove transition types & let go of
(smart) pointer wrapper types. We need to come to some agreement of what the
conversion constructors and copy assignment operator should take as arguments.

The use of 'const' previously served the purpose of not allowing the wrapper
object to be modified by these operators+constructors. We don't have those
wrappers any longer to contend with here.

I think the conversion constructor should now have the type as given here. The
use&placement of const isn't arbitrary - i.e., it should not be allowed to
modify the argument's value lest there is a good reason for allowing such. Your
suggestion either allows arbitrary modification of the pointed-to value, or
simply prevent modification of the pointer value (but not its contents.) Could
you explain the motivation for preferring either of those two?

[tkent, 2014/06/10 03:19:14]

I understand your point.  But it's not the topic of this CL.
WebFoo wrapper classes have function members which update the corresponding core
classes.  So passing |const Foo*| is not practical.

+    : m_private(const_cast<WebCore::SpeechGrammar*>(value))
 {
 }
 
-WebSpeechGrammar& WebSpeechGrammar::operator=(const PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>& value)
+WebSpeechGrammar& WebSpeechGrammar::operator=(const WebCore::SpeechGrammar* value)
 {
-    m_private = value;
+    m_private = const_cast<WebCore::SpeechGrammar*>(value);
     return *this;
 }
 
 WebURL WebSpeechGrammar::src() const
 {
     BLINK_ASSERT(m_private.get());
     return m_private->src();
 }
 
 float WebSpeechGrammar::weight() const
 {
     BLINK_ASSERT(m_private.get());
     return m_private->weight();
 }
 
 } // namespace blink