Fix android_run_skia script running with command line options

Fix android_run_skia script running with command line options

This script cannot recognize command line options when running bench:
e.g. android_run_skia bench --config 8888.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5102345029be75f089e083228e317545627ea1cb

[qiankun, 2014-06-04 03:19:12]

PTAL

[mtklein, 2014-06-04 13:51:59]

+Derek for a second opinion, because I'm stumped

Command line options (e.g. platform_tools/android/bin/android_run_skia bench
--match poly) work for me both with and without this CL.  Pretty sure they're
working for the whole team here and on all our bots.

What's the difference between @ and * in this context?  It's really hard to
search for bash syntax...

[djsollen, 2014-06-04 14:20:27]

In almost all cases @ and * are interchangable. The @ is supposed to expand each
element into its own string while * lumps them all into one string.

I'm fine with the change, but I'm curious what platform is causing the issue.

[qiankun, 2014-06-06 07:05:57]

On 2014/06/04 14:20:27, djsollen wrote:
> In almost all cases @ and * are interchangable. The @ is supposed to expand
each
> element into its own string while * lumps them all into one string.
> 
> I'm fine with the change, but I'm curious what platform is causing the issue.

My platform is Archlinux. I tried it on Ubuntu, no such issue existed. After
debugging it, I found bash add some single quotes on the command line strings.
command line: platform_tools/android/bin/android_run_skia --release bench
--config 8888 --match Xfermode_SrcATop
practical running command: /opt/android-sdk/platform-tools/adb shell
'/data/local/tmp/skia_launcher bench' --config 8888 --match 'Xfermode_SrcATop;
echo $? > /data/local/tmp/.skia_tmp_1402037686968493433'.

I don't know why Ubuntu has no such problem. But you can see similar added
single quotes for the following case both on Ubuntu and Archlinux.
~$ cat 1.sh 
#!/bin/bash -x

echo "hello $@"

Result on Ubuntu:
~$ ./1.sh --config 8888
+ echo 'hello --config' 8888
hello --config 8888

Result on Archlinux:
$ ./1.sh --config 8888
+ echo 'hello --config' 8888
hello --config 8888

[djsollen, 2014-06-06 13:05:43]

lgtm

[commit-bot: I haz the power, 2014-06-06 13:05:56]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/qiankun.miao@intel.com/314903003/1

[commit-bot: I haz the power, 2014-06-06 13:43:50]

Change committed as 5102345029be75f089e083228e317545627ea1cb