platform_tools/android/bin/android_run_skia - Issue 314903003: Fix android_run_skia script running with command line options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/bin/android_run_skia

Issue 314903003: Fix android_run_skia script running with command line options (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/bin/android_run_skia

diff --git a/platform_tools/android/bin/android_run_skia b/platform_tools/android/bin/android_run_skia

index 7bc9671b89f3b001f385a3cb5e0fc925c8b20c74..7176fd2c3629090ba355410777be46f43d1df28c 100755

--- a/platform_tools/android/bin/android_run_skia

+++ b/platform_tools/android/bin/android_run_skia

@@ -22,7 +22,7 @@ adb_push_if_needed "${SKIA_OUT}/$BUILDTYPE/lib/lib${APP_ARGS[0]}.so" /data/local

STATUS_FILENAME="/data/local/tmp/.skia_tmp_$(date +%s%N)"

$ADB ${DEVICE_SERIAL} shell \

- "/data/local/tmp/skia_launcher ${APP_ARGS[@]}; echo \$? > ${STATUS_FILENAME}"

+ "/data/local/tmp/skia_launcher ${APP_ARGS[*]}; echo \$? > ${STATUS_FILENAME}"

if [ -z "$($ADB $DEVICE_SERIAL shell 'if [ -f $STATUS_FILENAME ]; then echo exists; fi')" ]; then

echo "***********************************************************************"

echo "The application terminated unexpectedly and did not produce an exit code"

« no previous file with comments | « no previous file | no next file » | no next file with comments »