Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: chrome/browser/metrics_response_unittest.cc

Issue 3149: Porting changes in chrome/{browser,common}, also enabling more unit tests.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics_response_unittest.cc
===================================================================
--- chrome/browser/metrics_response_unittest.cc (revision 2402)
+++ chrome/browser/metrics_response_unittest.cc (working copy)
@@ -76,7 +76,7 @@
};
TEST(MetricsResponseTest, ParseResponse) {
- for (int i = 0; i < arraysize(response_cases); ++i) {
+ for (size_t i = 0; i < arraysize(response_cases); ++i) {
ResponseCase rcase = response_cases[i];
MetricsResponse response(rcase.response_xml);
EXPECT_TRUE(response.valid());
@@ -101,7 +101,7 @@
static const char* bogus_responses[] = {"", "<respo"};
TEST(MetricsResponseTest, ParseBogusResponse) {
- for (int i = 0; i < arraysize(bogus_responses); ++i) {
+ for (size_t i = 0; i < arraysize(bogus_responses); ++i) {
MetricsResponse response(bogus_responses[i]);
EXPECT_FALSE(response.valid());
}

Powered by Google App Engine
This is Rietveld 408576698