Porting changes in chrome/{browser,common}, also enabling more unit tests....

chrome/browser/metrics_response_unittest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "chrome/browser/metrics_response.h"
 #include "chrome/browser/metrics_service.h"
 #include "base/string_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 58 matching lines @@
     kLogResponse2,
     MetricsResponse::COLLECTOR_PROFILE |
         MetricsResponse::COLLECTOR_DOCUMENT |
         MetricsResponse::COLLECTOR_WINDOW,
     250, 900,
     true, true, true, false
   },
 };
 
 TEST(MetricsResponseTest, ParseResponse) {
-  for (int i = 0; i < arraysize(response_cases); ++i) {
+  for (size_t i = 0; i < arraysize(response_cases); ++i) {
     ResponseCase rcase = response_cases[i];
     MetricsResponse response(rcase.response_xml);
     EXPECT_TRUE(response.valid());
     EXPECT_EQ(rcase.collectors, response.collectors()) <<
         "Mismatch in case " << i;
     EXPECT_EQ(rcase.events, response.events()) << "Mismatch in case " << i;
     EXPECT_EQ(rcase.interval, response.interval()) << "Mismatch in case " << i;
     EXPECT_EQ(rcase.profile_active,
               response.collector_active(MetricsResponse::COLLECTOR_PROFILE)) <<
               "Mismatch in case " << i;
     EXPECT_EQ(rcase.window_active,
               response.collector_active(MetricsResponse::COLLECTOR_WINDOW)) <<
               "Mismatch in case " << i;
     EXPECT_EQ(rcase.document_active,
               response.collector_active(MetricsResponse::COLLECTOR_DOCUMENT)) <<
               "Mismatch in case " << i;
     EXPECT_EQ(rcase.ui_active,
               response.collector_active(MetricsResponse::COLLECTOR_UI)) <<
               "Mismatch in case " << i;
   }
 }
 
 static const char* bogus_responses[] = {"", "<respo"};
 TEST(MetricsResponseTest, ParseBogusResponse) {
-  for (int i = 0; i < arraysize(bogus_responses); ++i) {
+  for (size_t i = 0; i < arraysize(bogus_responses); ++i) {
     MetricsResponse response(bogus_responses[i]);
     EXPECT_FALSE(response.valid());
   }
 }