Issue 314853003: Move GuestViewBase::GetGuestPartitionConfigForSite to WebViewGuest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314853003: Move GuestViewBase::GetGuestPartitionConfigForSite to WebViewGuest. (Closed)

Created:
6 years, 6 months ago by Fady Samuel

Modified:
6 years, 6 months ago

Reviewers:
lazyboy

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move GuestViewBase::GetGuestPartitionConfigForSite to WebViewGuest. Guest site instances that encode partition information are webview specific so this CL moves that method to WebViewGuest for logical consistency. BUG=364141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274825

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -38 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/guest_view/guest_view_base.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/guest_view/guest_view_base.cc	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	chrome/browser/guest_view/web_view/web_view_guest.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/guest_view/web_view/web_view_guest.cc	View	2 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/314853003/1

6 years, 6 months ago (2014-06-04 05:06:49 UTC) #4

Message was sent while issue was closed.

Change committed as 274825

Expand Messages | Collapse Messages