Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5980)

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 314853003: Move GuestViewBase::GetGuestPartitionConfigForSite to WebViewGuest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/guest_view_base.cc
diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc
index 5acf36a2777507e8b67c769c1f87a313186073cc..770c7b0be0d97c8e382140874f1e2008cbbe2277 100644
--- a/chrome/browser/guest_view/guest_view_base.cc
+++ b/chrome/browser/guest_view/guest_view_base.cc
@@ -18,7 +18,6 @@
#include "content/public/browser/web_contents.h"
#include "content/public/common/url_constants.h"
#include "extensions/browser/event_router.h"
-#include "net/base/escape.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
using content::WebContents;
@@ -135,29 +134,6 @@ bool GuestViewBase::IsGuest(WebContents* web_contents) {
}
// static
-bool GuestViewBase::GetGuestPartitionConfigForSite(
- const GURL& site,
- std::string* partition_domain,
- std::string* partition_name,
- bool* in_memory) {
- if (!site.SchemeIs(content::kGuestScheme))
- return false;
-
- // Since guest URLs are only used for packaged apps, there must be an app
- // id in the URL.
- CHECK(site.has_host());
- *partition_domain = site.host();
- // Since persistence is optional, the path must either be empty or the
- // literal string.
- *in_memory = (site.path() != "/persist");
- // The partition name is user supplied value, which we have encoded when the
- // URL was created, so it needs to be decoded.
- *partition_name =
- net::UnescapeURLComponent(site.query(), net::UnescapeRule::NORMAL);
- return true;
-}
-
-// static
void GuestViewBase::GetDefaultContentSettingRules(
RendererContentSettingRules* rules,
bool incognito) {
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698