Omnibox: Send Input Type to Suggest Server

chrome/browser/autocomplete/autocomplete_input.h

Index: chrome/browser/autocomplete/autocomplete_input.h
diff --git a/chrome/browser/autocomplete/autocomplete_input.h b/chrome/browser/autocomplete/autocomplete_input.h
index b923e7b6542163ba51d00ce44c995eec3c0da602..07bc3987cbb91170e5fe35c35be274064d0c72b8 100644
--- a/chrome/browser/autocomplete/autocomplete_input.h
+++ b/chrome/browser/autocomplete/autocomplete_input.h
@@ -20,16 +20,18 @@ class AutocompleteInput {
   // cannot be opened as a URL, so it is marked as a QUERY; yet the user
   // probably intends to type more and have it eventually become a URL, so we
   // need to make sure we still run it through inline autocomplete.
+  // Warning: the value of this enum is sent to some suggest servers.  Do not
+  // reorder or delete entries.  Add new entries at the end.
   enum Type {
-    INVALID,        // Empty input
-    UNKNOWN,        // Valid input whose type cannot be determined
-    URL,            // Input autodetected as a URL
-    QUERY,          // Input autodetected as a query
-    FORCED_QUERY,   // Input forced to be a query by an initial '?'
+    INVALID = 0,       // Empty input
+    UNKNOWN = 1,       // Valid input whose type cannot be determined
+    URL = 2,           // Input autodetected as a URL
+    QUERY = 3,         // Input autodetected as a query
+    FORCED_QUERY = 4,  // Input forced to be a query by an initial '?'
   };

[Bart N., 2014/06/03 20:38:26]

I came across this inconsistency on the server side (OmniboxEventProto):

  // What kind of input the user provided.
  enum InputType {
    INVALID = 0;        // Empty input (should not reach here)
    UNKNOWN = 1;        // Valid input whose type cannot be determined
    REQUESTED_URL = 2;  // DEPRECATED. Input autodetected as UNKNOWN, which the
                        // user wants to treat as an URL by specifying a
                        // desired_tld
    URL = 3;            // Input autodetected as a URL
    QUERY = 4;          // Input autodetected as a query
    FORCED_QUERY = 5;   // Input forced to be a query by an initial '?'
  }
  optional InputType input_type = 8;

can you verify if this is OK (note the IDs off by 1 after presumably deleted
REQUESTED_URL value?).

[Mark P, 2014/06/03 20:53:33]

Good point.

The discrepancy is on the client side too.
https://code.google.com/p/chromium/codesearch#chromium/src/components/metrics...

Probably I should be uploading OmniboxEventProto::InputType rather than
AutocompleteInput::Type.  These things as you note are not identical.  However,
that would require including the metrics proto here, which I'm not sure if the
best idea.

Do you have an opinion?

Also, Peter what are your thoughts?

 
   // The type of page currently displayed.
-  // Note: when adding an element to this enum, please add it at the end
+  // Warning: when adding an element to this enum, please add it at the end
   // and update omnibox_event.proto::PageClassification and
   // omnibox_edit_model.cc::ClassifyPage() too.
   enum PageClassification {