Omnibox: Send Input Type to Suggest Server

chrome/browser/autocomplete/autocomplete_input.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/strings/string16.h"
 #include "url/gurl.h"
 #include "url/url_parse.h"
 
 // The user input for an autocomplete query.  Allows copying.
 class AutocompleteInput {
  public:
   // Note that the type below may be misleading.  For example, "http:/" alone
   // cannot be opened as a URL, so it is marked as a QUERY; yet the user
   // probably intends to type more and have it eventually become a URL, so we
   // need to make sure we still run it through inline autocomplete.
+  // Warning: the value of this enum is sent to some suggest servers.  Do not
+  // reorder or delete entries.  Add new entries at the end.
   enum Type {
-    INVALID,        // Empty input
-    UNKNOWN,        // Valid input whose type cannot be determined
-    URL,            // Input autodetected as a URL
-    QUERY,          // Input autodetected as a query
-    FORCED_QUERY,   // Input forced to be a query by an initial '?'
+    INVALID = 0,       // Empty input
+    UNKNOWN = 1,       // Valid input whose type cannot be determined
+    URL = 2,           // Input autodetected as a URL
+    QUERY = 3,         // Input autodetected as a query
+    FORCED_QUERY = 4,  // Input forced to be a query by an initial '?'
   };

[Bart N., 2014/06/03 20:38:26]

I came across this inconsistency on the server side (OmniboxEventProto):

  // What kind of input the user provided.
  enum InputType {
    INVALID = 0;        // Empty input (should not reach here)
    UNKNOWN = 1;        // Valid input whose type cannot be determined
    REQUESTED_URL = 2;  // DEPRECATED. Input autodetected as UNKNOWN, which the
                        // user wants to treat as an URL by specifying a
                        // desired_tld
    URL = 3;            // Input autodetected as a URL
    QUERY = 4;          // Input autodetected as a query
    FORCED_QUERY = 5;   // Input forced to be a query by an initial '?'
  }
  optional InputType input_type = 8;

can you verify if this is OK (note the IDs off by 1 after presumably deleted
REQUESTED_URL value?).

[Mark P, 2014/06/03 20:53:33]

Good point.

The discrepancy is on the client side too.
https://code.google.com/p/chromium/codesearch#chromium/src/components/metrics...

Probably I should be uploading OmniboxEventProto::InputType rather than
AutocompleteInput::Type.  These things as you note are not identical.  However,
that would require including the metrics proto here, which I'm not sure if the
best idea.

Do you have an opinion?

Also, Peter what are your thoughts?

 
   // The type of page currently displayed.
-  // Note: when adding an element to this enum, please add it at the end
+  // Warning: when adding an element to this enum, please add it at the end
   // and update omnibox_event.proto::PageClassification and
   // omnibox_edit_model.cc::ClassifyPage() too.
   enum PageClassification {
     // An invalid URL; shouldn't happen.
     INVALID_SPEC = 0,
 
     // chrome://newtab/.  This can be either the built-in version or a
     // replacement new tab page from an extension.  Note that when Instant
     // Extended is enabled, the new tab page will be reported as either
     // INSTANT_NTP_WITH_OMNIBOX_AS_STARTING_FOCUS or
@@ skipping 197 matching lines @@
   url::Parsed parts_;
   base::string16 scheme_;
   GURL canonicalized_url_;
   bool prevent_inline_autocomplete_;
   bool prefer_keyword_;
   bool allow_exact_keyword_match_;
   bool want_asynchronous_matches_;
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_