Move Dashing filterPath to a dashing utils file

Move Dashing filterPath to a dashing utils file

From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5

Committed: https://skia.googlesource.com/skia/+/a22ea1882391cc5c84136060636d5c952c1f34b3

[egdaniel, 2014-06-03 18:01:24]

PTAL

[reed1, 2014-06-03 18:16:56]

Why is anything made public? Would src/utils/SkDashPathPriv.h work for you?

We don't use namespace much in the core, but not a huge deal (esp. if it stays
private).

[egdaniel, 2014-06-03 18:26:11]

On 2014/06/03 18:16:56, reed1 wrote:
> Why is anything made public? Would src/utils/SkDashPathPriv.h work for you?

Yes you are right. It has been move to src/utils/SkDashPathPriv.h.

> 
> We don't use namespace much in the core, but not a huge deal (esp. if it stays
> private).

What is the preferred way if not namespace?

[bsalomon, 2014-06-03 18:28:33]

FYI, the idea here is to be able to invoke dashing from GrContext w/out having
to cons up an SkDashEffect.

On 2014/06/03 18:26:11, egdaniel wrote:
> On 2014/06/03 18:16:56, reed1 wrote:
> > Why is anything made public? Would src/utils/SkDashPathPriv.h work for you?
> 
> Yes you are right. It has been move to src/utils/SkDashPathPriv.h.

Is effects/ supposed to be able to include from src/utils?

[reed1, 2014-06-03 18:37:20]

On 2014/06/03 18:28:33, bsalomon wrote:
> FYI, the idea here is to be able to invoke dashing from GrContext w/out having
> to cons up an SkDashEffect.
> 
> On 2014/06/03 18:26:11, egdaniel wrote:
> > On 2014/06/03 18:16:56, reed1 wrote:
> > > Why is anything made public? Would src/utils/SkDashPathPriv.h work for
you?
> > 
> > Yes you are right. It has been move to src/utils/SkDashPathPriv.h.
> 
> Is effects/ supposed to be able to include from src/utils?

src/utils is basically the same as src/core

in general effects are supposed to be "clean, only using public apis", but I
think cheating in this direction is ok, at least for now.

[egdaniel, 2014-06-03 19:27:39]

Header has been moved to src/utils

[reed1, 2014-06-03 19:44:06]

api lgtm

[bsalomon, 2014-06-03 20:36:28]

lgtm

[egdaniel, 2014-06-04 13:03:43]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-06-04 13:04:34]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/314623004/20001

[commit-bot: I haz the power, 2014-06-04 13:19:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)

[egdaniel, 2014-06-04 13:26:25]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-06-04 13:26:38]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/314623004/40001

[rmistry, 2014-06-04 14:21:53]

The CQ bit was unchecked by rmistry@google.com

[rmistry, 2014-06-04 14:23:48]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-06-04 14:24:16]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/314623004/40001

[commit-bot: I haz the power, 2014-06-04 15:15:57]

Change committed as 576dcdc793a762ec63fbecdbfd5768066b548fe5

[egdaniel, 2014-06-04 16:58:26]

A revert of this CL has been created in
https://codereview.chromium.org/317663003/ by egdaniel@google.com.

The reason for reverting is: Need to create utils.gypi file and update chrome.

[egdaniel, 2014-06-11 13:38:03]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-06-11 13:38:59]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/314623004/100001

[commit-bot: I haz the power, 2014-06-11 13:51:56]

Change committed as a22ea1882391cc5c84136060636d5c952c1f34b3