Issue 3146044: Remove NEWNS from the setuid sandbox....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3146044: Remove NEWNS from the setuid sandbox.... (Closed)

Created:
10 years, 4 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
mal, agl

CC:
chromium-reviews, Markus (顧孟勤), Evan Martin

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove NEWNS from the setuid sandbox. This can cause issues with the automounter on ubuntu. R= agl BUG= http://b/2824277 TEST= see bug. Or see traffic on the bug drop to <10 comments/day. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57469

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	sandbox/linux/suid/sandbox.c	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mal

I didn't see another codereview for this, and I'd like to get it in quickly ...

10 years, 4 months ago (2010-08-26 04:08:35 UTC) #1

Markus (顧孟勤)

LGTM Adam was going to submit the same changelist in the morning, I think. But ...

10 years, 4 months ago (2010-08-26 04:45:59 UTC) #2

mal

I've committed and merged it over to the 472 branch. I wanted to make sure ...

10 years, 4 months ago (2010-08-26 06:32:59 UTC) #3

agl

10 years, 4 months ago (2010-08-26 14:42:52 UTC) #4

On Thu, Aug 26, 2010 at 2:32 AM,  <mal@google.com> wrote:
> I've committed and merged it over to the 472 branch. I wanted to make sure
> it's
> in the build for Chrome 6 that QA will start testing tomorrow morning.

LGTM. Thanks for that.


AGL

Expand Messages | Collapse Messages