Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 3146044: Remove NEWNS from the setuid sandbox.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
7 years ago by Mark Larson
6 years, 4 months ago
mal, agl
chromium-reviews, Markus (顧孟勤), Evan Martin


Remove NEWNS from the setuid sandbox. This can cause issues with the automounter on ubuntu. R= agl BUG= http://b/2824277 TEST= see bug. Or see traffic on the bug drop to <10 comments/day. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M sandbox/linux/suid/sandbox.c View 2 chunks +0 lines, -4 lines 0 comments Download
Commit queue not available (can’t edit this change).


Total messages: 4 (0 generated)
I didn't see another codereview for this, and I'd like to get it in quickly ...
7 years ago (2010-08-26 04:08:35 UTC) #1
Markus (顧孟勤)
LGTM Adam was going to submit the same changelist in the morning, I think. But ...
7 years ago (2010-08-26 04:45:59 UTC) #2
I've committed and merged it over to the 472 branch. I wanted to make sure ...
7 years ago (2010-08-26 06:32:59 UTC) #3
7 years ago (2010-08-26 14:42:52 UTC) #4
On Thu, Aug 26, 2010 at 2:32 AM,  <> wrote:
> I've committed and merged it over to the 472 branch. I wanted to make sure
> it's
> in the build for Chrome 6 that QA will start testing tomorrow morning.

LGTM. Thanks for that.

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b