Chromium Code Reviews
Help | Chromium Project | Sign in
(358)

Issue 3146044: Remove NEWNS from the setuid sandbox.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Mark Larson
Modified:
2 years, 11 months ago
Reviewers:
mal, agl
CC:
chromium-reviews_chromium.org, Markus (顧孟勤), Evan Martin
Visibility:
Public.

Description

Remove NEWNS from the setuid sandbox.

This can cause issues with the automounter on ubuntu.

R= agl
BUG= http://b/2824277
TEST= see bug. Or see traffic on the bug drop to <10 comments/day.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Lint Patch
M sandbox/linux/suid/sandbox.c View 2 chunks +0 lines, -4 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
mal
I didn't see another codereview for this, and I'd like to get it in quickly ...
3 years, 7 months ago #1
Markus (顧孟勤)
LGTM Adam was going to submit the same changelist in the morning, I think. But ...
3 years, 7 months ago #2
mal
I've committed and merged it over to the 472 branch. I wanted to make sure ...
3 years, 7 months ago #3
agl
3 years, 7 months ago #4
On Thu, Aug 26, 2010 at 2:32 AM,  <mal@google.com> wrote:
> I've committed and merged it over to the 472 branch. I wanted to make sure
> it's
> in the build for Chrome 6 that QA will start testing tomorrow morning.

LGTM. Thanks for that.


AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434