Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314583003: Cleanup: Mark some ash resources as CrOS only. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Cleanup: Mark some ash resources as CrOS only. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275323

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -307 lines) Patch
M ash/ash_chromeos_strings.grdp View 5 chunks +242 lines, -9 lines 0 comments Download
M ash/ash_strings.grd View 10 chunks +0 lines, -239 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 6 chunks +57 lines, -59 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Lei Zhang
Safe to assume "not used on Linux" -> "CroS only" ?
6 years, 6 months ago (2014-06-03 07:53:55 UTC) #1
oshima
On 2014/06/03 07:53:55, Lei Zhang wrote: > Safe to assume "not used on Linux" -> ...
6 years, 6 months ago (2014-06-03 16:57:16 UTC) #2
Lei Zhang
On 2014/06/03 16:57:16, oshima wrote: > On 2014/06/03 07:53:55, Lei Zhang wrote: > > Safe ...
6 years, 6 months ago (2014-06-03 23:15:03 UTC) #3
oshima
lgtm
6 years, 6 months ago (2014-06-04 00:36:28 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-04 19:34:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/314583003/30004
6 years, 6 months ago (2014-06-04 19:36:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 22:40:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 22:46:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10619)
6 years, 6 months ago (2014-06-04 22:46:21 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-04 22:53:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/314583003/30004
6 years, 6 months ago (2014-06-04 22:55:33 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 23:08:36 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 23:18:27 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10643)
6 years, 6 months ago (2014-06-04 23:18:28 UTC) #14
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-06 04:05:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/314583003/30004
6 years, 6 months ago (2014-06-06 04:06:42 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 04:51:48 UTC) #17
Message was sent while issue was closed. 
Change committed as 275323

Powered by Google App Engine
This is Rietveld 408576698