Issue 314553002: Add v8::Promise::Then.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314553002: Add v8::Promise::Then. (Closed)

Created:
6 years, 6 months ago by yhirano

Modified:
6 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/external/v8.git@master

Visibility:
Public.

Add v8::Promise::Then. Blink needs v8::Promise::Then to implement ScriptPromise::then. Blink-side CL: https://codereview.chromium.org/316453002 BUG=371288 LOG=Y R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21805

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -1 line)			Patch
M	include/v8.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/contexts.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/promise.js	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+66 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

rossberg

LGTM, although I don't buy the premise that this is what Blink should use.

6 years, 6 months ago (2014-06-03 10:47:54 UTC) #2

rossberg

On 2014/06/12 11:12:58, yhirano wrote: > Could you please commit this CL? Oops, sorry, done.

6 years, 6 months ago (2014-06-12 11:34:05 UTC) #5

Message was sent while issue was closed.

Thanks!