Issue 316453002: Use v8::Promise::Then in ScriptPromise::then.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 316453002: Use v8::Promise::Then in ScriptPromise::then. (Closed)

Created:
6 years, 6 months ago by yhirano

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Use v8::Promise::Then in ScriptPromise::then. ScriptPromise::then should use v8::Promise::Then in order to handle multiply-wrapped Promises correctly. BUG=371288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176194

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	LayoutTests/fast/js/Promise-native-then.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/bindings/v8/ScriptPromise.cpp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/316453002/20001

6 years, 6 months ago (2014-06-16 08:24:35 UTC) #4

Message was sent while issue was closed.

Change committed as 176194