Issue 314543002: Revert of Try TSAN blacklist for SkGLContextHelper::init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314543002: Revert of Try TSAN blacklist for SkGLContextHelper::init. (Closed)

Created:
6 years, 6 months ago by mtklein

Modified:
6 years, 6 months ago

Reviewers:
mtklein_C

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/) Reason for revert: the bot's clang doesn't know -fsanitize-blacklist Original issue's description: > Try TSAN blacklist for SkGLContextHelper::init. > > Submitting to test this; this particular problem only happens on the bot. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478 TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/59ef7704f142c4189532340284ece9a0b2bdb0ab

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	gyp/common_conditions.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
D	tools/tsan.blacklist	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	tools/tsan.supp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Try TSAN blacklist for SkGLContextHelper::init.

6 years, 6 months ago (2014-06-03 02:33:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/314543002/1

6 years, 6 months ago (2014-06-03 02:34:15 UTC) #2

commit-bot: I haz the power

6 years, 6 months ago (2014-06-03 02:34:23 UTC) #3

Message was sent while issue was closed.

Change committed as 59ef7704f142c4189532340284ece9a0b2bdb0ab