Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: tools/tsan.supp

Issue 314543002: Revert of Try TSAN blacklist for SkGLContextHelper::init. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/tsan.blacklist ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tsan.supp
diff --git a/tools/tsan.supp b/tools/tsan.supp
index 3b10e4e997a065fb4a2ff302712e08f371e066e0..c997058db22d16d4334e4489870ea20e6edc26b3 100644
--- a/tools/tsan.supp
+++ b/tools/tsan.supp
@@ -4,6 +4,13 @@
# WebP races (harmlessly) choosing function pointers for SIMD versions of some of its functions.
race:third_party/externals/libwebp
+
+# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
+# Having trouble getting this suppression to match.
+# We've tried: race:swrast_dri.so
+# race:SkGLContextHelper::init
+# Maybe because it's diagnosed as a use-after-free, not as a race?
+race:SkGLContextHelper
# Threadsafe, should be ported to SkLazyPtr.
race:SkFontHost_FreeType
« no previous file with comments | « tools/tsan.blacklist ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698