Issue 3143005: Autocomplete entries submitted are limited in number.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3143005: Autocomplete entries submitted are limited in number. (Closed)

Created:
10 years, 4 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
inferno

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

Autocomplete entries submitted are limited in number. Limits the number of Autocomplete entries added to the WebDB, per form submission, to a maximum of 256. If elements occur that have duplicate names, only the first occurrence is added. BUG=51727 TEST=WebDatabaseTest.Autofill_AddFormFieldValues Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55781

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing nits. #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
M	chrome/browser/webdata/web_database.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

inferno

LGTM. Thanks for fixing it so quick. http://codereview.chromium.org/3143005/diff/1/4 File chrome/browser/webdata/web_database_unittest.cc (right): http://codereview.chromium.org/3143005/diff/1/4#newcode916 chrome/browser/webdata/web_database_unittest.cc:916: // first ...

10 years, 4 months ago (2010-08-11 19:10:39 UTC) #2

dhollowa

10 years, 4 months ago (2010-08-11 19:31:22 UTC) #3

http://codereview.chromium.org/3143005/diff/1/4
File chrome/browser/webdata/web_database_unittest.cc (right):

http://codereview.chromium.org/3143005/diff/1/4#newcode916
chrome/browser/webdata/web_database_unittest.cc:916: // first value of each gets
added.  Related to security issue:
On 2010/08/11 19:10:39, inferno wrote:
> nit. one space instead of two.

Done.

http://codereview.chromium.org/3143005/diff/1/4#newcode938
chrome/browser/webdata/web_database_unittest.cc:938: 0));
On 2010/08/11 19:10:39, inferno wrote:
> nit. Align to ( or 4 spaces.

Done.

Expand Messages | Collapse Messages