Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 3143005: Autocomplete entries submitted are limited in number. (Closed)

Created:
8 years, 6 months ago by dhollowa
Modified:
7 years, 9 months ago
Reviewers:
inferno
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Autocomplete entries submitted are limited in number. Limits the number of Autocomplete entries added to the WebDB, per form submission, to a maximum of 256. If elements occur that have duplicate names, only the first occurrence is added. BUG=51727 TEST=WebDatabaseTest.Autofill_AddFormFieldValues Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55781

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M chrome/browser/webdata/web_database.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_database_unittest.cc View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dhollowa
8 years, 6 months ago (2010-08-11 18:59:36 UTC) #1
inferno
LGTM. Thanks for fixing it so quick. http://codereview.chromium.org/3143005/diff/1/4 File chrome/browser/webdata/web_database_unittest.cc (right): http://codereview.chromium.org/3143005/diff/1/4#newcode916 chrome/browser/webdata/web_database_unittest.cc:916: // first ...
8 years, 6 months ago (2010-08-11 19:10:39 UTC) #2
dhollowa
8 years, 6 months ago (2010-08-11 19:31:22 UTC) #3
http://codereview.chromium.org/3143005/diff/1/4
File chrome/browser/webdata/web_database_unittest.cc (right):

http://codereview.chromium.org/3143005/diff/1/4#newcode916
chrome/browser/webdata/web_database_unittest.cc:916: // first value of each gets
added.  Related to security issue:
On 2010/08/11 19:10:39, inferno wrote:
> nit. one space instead of two.

Done.

http://codereview.chromium.org/3143005/diff/1/4#newcode938
chrome/browser/webdata/web_database_unittest.cc:938: 0));
On 2010/08/11 19:10:39, inferno wrote:
> nit. Align to ( or 4 spaces.

Done.

Powered by Google App Engine
This is Rietveld 408576698