Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 314283003: Removing the word "tabs" from the extensions permissions message of accessing "browsing activity". (Closed)

Created:
6 years, 6 months ago by mhm
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing the word "tabs" from the extensions permissions message of accessing "browsing activity". BUG=380839 R=meacer, jww Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275672

Patch Set 1 #

Patch Set 2 : Changed some other places for the string. #

Total comments: 1

Patch Set 3 : Removed the change from the file "generated_resources_en-GB.xtb" because it is autogenerated. #

Patch Set 4 : Undo GB translations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/permission_warnings.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
mhm
Extensions already have access to tabs without the "tabs" permission, so the reference to "tabs" ...
6 years, 6 months ago (2014-06-05 23:17:10 UTC) #1
Please use chromium.org acct
6 years, 6 months ago (2014-06-05 23:28:04 UTC) #2
meacer
On 2014/06/05 23:28:04, meacer wrote: (looks like this went to my personal gmail account, added ...
6 years, 6 months ago (2014-06-05 23:28:57 UTC) #3
meacer
On 2014/06/05 23:28:57, Mustafa Emre Acer wrote: > On 2014/06/05 23:28:04, meacer wrote: > > ...
6 years, 6 months ago (2014-06-05 23:39:35 UTC) #4
jww
lgtm
6 years, 6 months ago (2014-06-05 23:55:30 UTC) #5
mhm
kalman@ can you please have a look at this.
6 years, 6 months ago (2014-06-06 22:38:22 UTC) #6
not at google - send to devlin
lgtm https://codereview.chromium.org/314283003/diff/20001/chrome/app/resources/generated_resources_en-GB.xtb File chrome/app/resources/generated_resources_en-GB.xtb (right): https://codereview.chromium.org/314283003/diff/20001/chrome/app/resources/generated_resources_en-GB.xtb#newcode1128 chrome/app/resources/generated_resources_en-GB.xtb:1128: <translation id="8562720436766170629">Access your browsing activity</translation> I don't think ...
6 years, 6 months ago (2014-06-06 22:51:47 UTC) #7
mhm
The CQ bit was checked by mohammed@chromium.org
6 years, 6 months ago (2014-06-06 23:10:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/314283003/20001
6 years, 6 months ago (2014-06-06 23:12:40 UTC) #9
jww
The CQ bit was unchecked by jww@chromium.org
6 years, 6 months ago (2014-06-06 23:15:02 UTC) #10
jww
On 2014/06/06 23:12:40, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-06 23:15:19 UTC) #11
mhm
Ooops! Will fix it now. On Fri, Jun 6, 2014 at 4:15 PM, <jww@chromium.org> wrote: ...
6 years, 6 months ago (2014-06-06 23:17:13 UTC) #12
mhm
6 years, 6 months ago (2014-06-06 23:23:33 UTC) #13
mhm
6 years, 6 months ago (2014-06-06 23:32:29 UTC) #14
mhm
The CQ bit was checked by mohammed@chromium.org
6 years, 6 months ago (2014-06-06 23:32:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/314283003/60001
6 years, 6 months ago (2014-06-06 23:34:10 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 09:39:13 UTC) #17
Message was sent while issue was closed.
Change committed as 275672

Powered by Google App Engine
This is Rietveld 408576698