Issue 314283002: Fix resolving loop in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314283002: Fix resolving loop in GN (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix resolving loop in GN This loop doesn't loop over all items. Originally I was inserting the new items at the end and this made sense, but then decided to insert them in the middle and the loop length computations were off. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275830

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tools/gn/target.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 6 months ago (2014-06-09 17:29:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r275830 (presubmit successful).