Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: tools/gn/target.cc

Issue 314283002: Fix resolving loop in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 2ddbde91cf7fe964d76eb7a415bcdec7b7bed223..a83c60e4491f43f77b63a94a2e1130f75bda2116 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -102,8 +102,7 @@ void Target::OnResolved() {
// group's deps. We insert the new deps immediately after the group so that
// the ordering is preserved. We need to keep the original group so that any
// flags, etc. that it specifies itself are applied to us.
- size_t original_deps_size = deps_.size();
- for (size_t i = 0; i < original_deps_size; i++) {
+ for (size_t i = 0; i < deps_.size(); i++) {
const Target* dep = deps_[i].ptr;
if (dep->output_type_ == GROUP) {
deps_.insert(deps_.begin() + i + 1, dep->deps_.begin(), dep->deps_.end());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698