Issue 314253002: [Android] Add a field trial to disable enhanced bookmark image saving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 314253002: [Android] Add a field trial to disable enhanced bookmark image saving. (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)

Modified:
6 years, 6 months ago

Reviewers:
noyau (Ping after 24h), sky

CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, Ted C, Yaron

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Add a field trial to disable enhanced bookmark image saving. We will be saving bookmark salient images even if enhanced bookmark feature is not turned on. This is to have some images available when we turn on the feature. For just in case, add a field trial to disable saving images. BUG=368034 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275381

Patch Set 1 #

Patch Set 2 : .. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	chrome/browser/bookmarks/enhanced_bookmarks_features.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/bookmarks/enhanced_bookmarks_features.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kibeom Kim (inactive)

Almost identical to IsBookmarkImageFetchingEnabled() function at https://chrome-internal.googlesource.com/bling/chromium.git/+/master/ios_internal/chrome/common/experimental_flags.mm

6 years, 6 months ago (2014-06-05 21:36:58 UTC) #1

Kibeom Kim (inactive)

The CQ bit was checked by kkimlabs@chromium.org

6 years, 6 months ago (2014-06-05 23:25:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/314253002/20001

6 years, 6 months ago (2014-06-05 23:26:14 UTC) #4

Message was sent while issue was closed.

Change committed as 275381

Expand Messages | Collapse Messages