Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.cc

Issue 314253002: [Android] Add a field trial to disable enhanced bookmark image saving. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: .. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/enhanced_bookmarks_features.cc
diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
index c768f9aa7b38ff746650b88dff1c327a6e8b9441..309b1081b55a1c8cb7dd7d8805ff9e3c04fb07cc 100644
--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.cc
@@ -174,6 +174,22 @@ bool IsEnhancedBookmarksExperimentEnabled() {
return IsEnhancedBookmarksExperimentEnabledFromFinch();
}
+#if defined(OS_ANDROID)
+bool IsEnhancedBookmarkImageFetchingEnabled() {
+ if (IsEnhancedBookmarksExperimentEnabled())
+ return true;
+
+ // Salient images are collected from visited bookmarked pages even if the
+ // enhanced bookmark feature is turned off. This is to have some images
+ // available so that in the future, when the feature is turned on, the user
+ // experience is not a big list of flat colors. However as a precautionary
+ // measure it is possible to disable this collection of images from finch.
+ std::string disable_fetching = chrome_variations::GetVariationParamValue(
+ kFieldTrialName, "DisableImagesFetching");
+ return disable_fetching.empty();
+}
+#endif
+
bool IsEnableDomDistillerSet() {
if (CommandLine::ForCurrentProcess()->
HasSwitch(switches::kEnableDomDistiller)) {
« no previous file with comments | « chrome/browser/bookmarks/enhanced_bookmarks_features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698