Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 314223002: Fix copy-paste error: description if Javascript in CSS insertion API (Closed)

Created:
6 years, 6 months ago by Mark Dittmer
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix copy-paste error: description if Javascript in CSS insertion API BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275330

Patch Set 1 #

Patch Set 2 : Rewrite descriptions to match extensions insertCSS() descriptions. Remove erroneous parameter from … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/common/extensions/api/webview.json View 1 4 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Dittmer
Need owners review to commit fix in webview.insertCSS() API description.
6 years, 6 months ago (2014-06-05 19:17:29 UTC) #1
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-05 19:29:33 UTC) #2
not at google - send to devlin
though "stylesheet" would be more accurate than "script"
6 years, 6 months ago (2014-06-05 19:29:58 UTC) #3
Mark Dittmer
The CQ bit was checked by markdittmer@chromium.org
6 years, 6 months ago (2014-06-05 19:42:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markdittmer@chromium.org/314223002/10001
6 years, 6 months ago (2014-06-05 19:43:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 00:00:21 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:03:04 UTC) #7
Message was sent while issue was closed. 
Change committed as 275330

Powered by Google App Engine
This is Rietveld 408576698