Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/common/extensions/api/webview.json

Issue 314223002: Fix copy-paste error: description if Javascript in CSS insertion API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite descriptions to match extensions insertCSS() descriptions. Remove erroneous parameter from … Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/webview.json
diff --git a/chrome/common/extensions/api/webview.json b/chrome/common/extensions/api/webview.json
index 8b995b22a1d5feb72b86d96eb271a3c4cb19f243..af6d2e4fffb53c2c75cbf87cd6dc584c04867729 100644
--- a/chrome/common/extensions/api/webview.json
+++ b/chrome/common/extensions/api/webview.json
@@ -345,7 +345,7 @@
{
"type": "string",
"name": "src",
- "description": "The src of the guest <webview> process."
+ "description": "The src of the guest <webview> tag."
},
{
"$ref": "tabs.InjectDetails",
@@ -372,7 +372,7 @@
{
"name": "insertCSS",
"type": "function",
- "description": "Injects JavaScript code into a <webview> page.",
+ "description": "Injects CSS into a <webview> page. For details, see the <a href='/extensions/content_scripts#pi'>programmatic injection</a> section of the content scripts doc.",
"parameters": [
{
"type": "integer",
@@ -382,27 +382,19 @@
{
"type": "string",
"name": "src",
- "description": "The src of the guest <webview> process."
+ "description": "The src of the guest <webview> tag."
},
{
"$ref": "tabs.InjectDetails",
"name": "details",
- "description": "Details of the script to run."
+ "description": "Details of the CSS text to insert."
},
{
"type": "function",
"name": "callback",
"optional": true,
- "description": "Called after all the JavaScript has been executed.",
- "parameters": [
- {
- "name": "result",
- "optional": true,
- "type": "array",
- "items": {"type": "any", "minimum": 0},
- "description": "The result of the script in every injected frame."
- }
- ]
+ "description": "Called when all the CSS has been inserted.",
+ "parameters": []
}
]
},
@@ -713,4 +705,3 @@
]
}
]
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698