Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 3142018: Add a header file which got missed out in the initial commit (Closed)

Created:
10 years, 4 months ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
jorlow
CC:
chromium-reviews
Visibility:
Public.

Description

Add a header file which got missed out in the initial commit. This header is not required on windows and mac since the types are defined already for those platforms. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56503

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M speex/README.chromium View 1 chunk +4 lines, -1 line 1 comment Download
A speex/include/speex/speex_config_types.h View 1 chunk +11 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Satish
10 years, 4 months ago (2010-08-18 09:17:40 UTC) #1
jorlow
10 years, 4 months ago (2010-08-18 09:26:21 UTC) #2
LGTM

http://codereview.chromium.org/3142018/diff/1/2
File speex/README.chromium (right):

http://codereview.chromium.org/3142018/diff/1/2#newcode8
speex/README.chromium:8: of speex-1.2rc1 with all the unused files removed and
the following changes:
with the following changes?

http://codereview.chromium.org/3142018/diff/1/3
File speex/include/speex/speex_config_types.h (right):

http://codereview.chromium.org/3142018/diff/1/3#newcode1
speex/include/speex/speex_config_types.h:1: #ifndef __SPEEX_TYPES_H__
license on top?

Powered by Google App Engine
This is Rietveld 408576698