Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 314163003: Fix msvs-ninja clean build command / target. (Closed)

Created:
6 years, 6 months ago by bungeman-chromium
Modified:
6 years, 6 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix msvs-ninja clean build command / target. Currently the clean command is specified as ninja.exe -C $(OutDir) -t clean $(ProjectName) but _BuildCommandLineForRuleRaw sees 'clean' as a path, calling _FixPath on it. This is not a problem for Chromium because it does not set --generator-output. As a result fixpath_prefix is None and no adjustment is made to paths. Skia, however, does set --generator-output, and so an attempt is made to adjust paths with _FixPath. As a result, with Skia the msvs 'Clean' target contains ninja.exe -C $(OutDir) -t ../../gyp/clean $(ProjectName) This change changes the command to ninja.exe -C $(OutDir) -tclean $(ProjectName) which it valid for ninja, but _BuildCommandLineForRuleRaw will not _FixPath it. BUG=skia:2439 R=sbaig1@bloomberg.net Committed: https://code.google.com/p/gyp/source/detail?r=1929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pylib/gyp/generator/msvs.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-chromium
6 years, 6 months ago (2014-06-05 17:27:23 UTC) #1
Shezan Baig (Bloomberg)
lgtm, thanks!
6 years, 6 months ago (2014-06-05 17:30:47 UTC) #2
bungeman-chromium
6 years, 6 months ago (2014-06-05 18:26:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1929.

Powered by Google App Engine
This is Rietveld 408576698