Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: pylib/gyp/generator/msvs.py

Issue 314163003: Fix msvs-ninja clean build command / target. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import copy 5 import copy
6 import ntpath 6 import ntpath
7 import os 7 import os
8 import posixpath 8 import posixpath
9 import re 9 import re
10 import subprocess 10 import subprocess
(...skipping 1810 matching lines...) Expand 10 before | Expand all | Expand 10 after
1821 path_to_ninja, 1821 path_to_ninja,
1822 '-C', 1822 '-C',
1823 '$(OutDir)', 1823 '$(OutDir)',
1824 '$(ProjectName)', 1824 '$(ProjectName)',
1825 ] 1825 ]
1826 if not spec.get('msvs_external_builder_clean_cmd'): 1826 if not spec.get('msvs_external_builder_clean_cmd'):
1827 spec['msvs_external_builder_clean_cmd'] = [ 1827 spec['msvs_external_builder_clean_cmd'] = [
1828 path_to_ninja, 1828 path_to_ninja,
1829 '-C', 1829 '-C',
1830 '$(OutDir)', 1830 '$(OutDir)',
1831 '-t', 1831 '-tclean',
1832 'clean',
1833 '$(ProjectName)', 1832 '$(ProjectName)',
1834 ] 1833 ]
1835 1834
1836 1835
1837 def CalculateVariables(default_variables, params): 1836 def CalculateVariables(default_variables, params):
1838 """Generated variables that require params to be known.""" 1837 """Generated variables that require params to be known."""
1839 1838
1840 generator_flags = params.get('generator_flags', {}) 1839 generator_flags = params.get('generator_flags', {})
1841 1840
1842 # Select project file format version (if unset, default to auto detecting). 1841 # Select project file format version (if unset, default to auto detecting).
(...skipping 1472 matching lines...) Expand 10 before | Expand all | Expand 10 after
3315 action_spec.extend( 3314 action_spec.extend(
3316 # TODO(jeanluc) 'Document' for all or just if as_sources? 3315 # TODO(jeanluc) 'Document' for all or just if as_sources?
3317 [['FileType', 'Document'], 3316 [['FileType', 'Document'],
3318 ['Command', command], 3317 ['Command', command],
3319 ['Message', description], 3318 ['Message', description],
3320 ['Outputs', outputs] 3319 ['Outputs', outputs]
3321 ]) 3320 ])
3322 if additional_inputs: 3321 if additional_inputs:
3323 action_spec.append(['AdditionalInputs', additional_inputs]) 3322 action_spec.append(['AdditionalInputs', additional_inputs])
3324 actions_spec.append(action_spec) 3323 actions_spec.append(action_spec)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698