chrome/installer/linux/common/wrapper - Issue 314133003: Sanitize standard file descriptors in launcher script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/linux/common/wrapper

Issue 314133003: Sanitize standard file descriptors in launcher script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/linux/common/wrapper

diff --git a/chrome/installer/linux/common/wrapper b/chrome/installer/linux/common/wrapper

index e174637c52f595c7856f820858996f7724211205..d06b6741442a284a0e058b05a52de12de8f795ba 100755

--- a/chrome/installer/linux/common/wrapper

+++ b/chrome/installer/linux/common/wrapper

@@ -73,6 +73,12 @@ if [[ -n "$CHROME_USER_DATA_DIR" ]]; then

PROFILE_DIRECTORY_FLAG="--user-data-dir=$CHROME_USER_DATA_DIR"

+# Sanitize std{in,out,err} because they'll be shared with untrusted child

+# processes (http://crbug.com/376567).

+exec < /dev/null

+exec > >(exec cat)

Lei Zhang 2014/06/05 19:04:27 bash on my machine doesn't seem to recognize this

Lei Zhang 2014/06/05 19:05:32 Err, n/m, ran it with the wrong shell.

+exec 2> >(exec cat >&2)

# Note: exec -a below is a bashism.

exec -a "$0" "$HERE/@@PROGNAME@@" @@DEFAULT_FLAGS@@ "$PROFILE_DIRECTORY_FLAG" \

"$@"

« no previous file with comments | « no previous file | no next file » | no next file with comments »