chrome/installer/linux/common/wrapper - Issue 314133003: Sanitize standard file descriptors in launcher script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/linux/common/wrapper

Issue 314133003: Sanitize standard file descriptors in launcher script (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 #	2 #

3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.	3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 # Let the wrapped binary know that it has been run through the wrapper.	7 # Let the wrapped binary know that it has been run through the wrapper.

8 export CHROME_WRAPPER="`readlink -f "$0"`"	8 export CHROME_WRAPPER="`readlink -f "$0"`"

9	9

10 HERE="`dirname "$CHROME_WRAPPER"`"	10 HERE="`dirname "$CHROME_WRAPPER"`"

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 --enable-logging=stderr --log-level=0	66 --enable-logging=stderr --log-level=0

67 fi	67 fi

68 fi	68 fi

69	69

70 # Make sure that the profile directory specified in the environment, if any,	70 # Make sure that the profile directory specified in the environment, if any,

71 # overrides the default.	71 # overrides the default.

72 if [[ -n "$CHROME_USER_DATA_DIR" ]]; then	72 if [[ -n "$CHROME_USER_DATA_DIR" ]]; then

73 PROFILE_DIRECTORY_FLAG="--user-data-dir=$CHROME_USER_DATA_DIR"	73 PROFILE_DIRECTORY_FLAG="--user-data-dir=$CHROME_USER_DATA_DIR"

74 fi	74 fi

75	75

	76 # Sanitize std{in,out,err} because they'll be shared with untrusted child

	77 # processes (http://crbug.com/376567).

	78 exec < /dev/null

	79 exec > >(exec cat)
	Lei Zhang 2014/06/05 19:04:27 bash on my machine doesn't seem to recognize this bash on my machine doesn't seem to recognize this as a valid command. Lei Zhang 2014/06/05 19:05:32 Err, n/m, ran it with the wrong shell. Show quoted text On 2014/06/05 19:04:27, Lei Zhang wrote: > bash on my machine doesn't seem to recognize this as a valid command. Err, n/m, ran it with the wrong shell.
	80 exec 2> >(exec cat >&2)

	81

76 # Note: exec -a below is a bashism.	82 # Note: exec -a below is a bashism.

77 exec -a "$0" "$HERE/@@PROGNAME@@" @@DEFAULT_FLAGS@@ "$PROFILE_DIRECTORY_FLAG" \	83 exec -a "$0" "$HERE/@@PROGNAME@@" @@DEFAULT_FLAGS@@ "$PROFILE_DIRECTORY_FLAG" \

78 "$@"	84 "$@"

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »