Sanitize standard file descriptors in launcher script

Sanitize standard file descriptors in launcher script

BUG=376567
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275522

[jln (very slow on Chromium), 2014-06-05 17:59:10]

This lgtm, thanks!

Lei?

[Lei Zhang, 2014-06-05 19:04:28]

https://codereview.chromium.org/314133003/diff/1/chrome/installer/linux/commo...
File chrome/installer/linux/common/wrapper (right):

https://codereview.chromium.org/314133003/diff/1/chrome/installer/linux/commo...
chrome/installer/linux/common/wrapper:79: exec > >(exec cat)
bash on my machine doesn't seem to recognize this as a valid command.

[Lei Zhang, 2014-06-05 19:05:32]

https://codereview.chromium.org/314133003/diff/1/chrome/installer/linux/commo...
File chrome/installer/linux/common/wrapper (right):

https://codereview.chromium.org/314133003/diff/1/chrome/installer/linux/commo...
chrome/installer/linux/common/wrapper:79: exec > >(exec cat)
On 2014/06/05 19:04:27, Lei Zhang wrote:
> bash on my machine doesn't seem to recognize this as a valid command.

Err, n/m, ran it with the wrong shell.

[Lei Zhang, 2014-06-05 19:07:33]

lgtm

Please check and make sure about:memory isn't confused either.

[Lei Zhang, 2014-06-05 19:39:01]

BTW, in base/process/launch_posix.cc, we run dup2(dev_null_fd, STDIN_FILENO);

[mdempsky, 2014-06-06 17:46:21]

On 2014/06/05 19:07:33, Lei Zhang wrote:
> Please check and make sure about:memory isn't confused either.

Done.  It doesn't show the "cat" child processes at all.

> BTW, in base/process/launch_posix.cc, we run dup2(dev_null_fd, STDIN_FILENO);

Hm, good point.  I'm leaning towards keeping the "exec < /dev/null" since I
don't think people should be reading from stdin even in the browser process, but
I guess we could remove it.  Shrug?

[mdempsky, 2014-06-06 18:00:14]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:01:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mdempsky@chromium.org/314133003/1

[commit-bot: I haz the power, 2014-06-06 21:02:53]

Change committed as 275522