Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 313993002: Bindings: Add ScalarValueString support (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Incorporate review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index 7f7b83b348f2525957d2cc759bf2e2329044ffc3..c6879575c6993e04f59befdc43e534fc150aee74 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -131,7 +131,9 @@ def generate_method(interface, method):
is_raises_exception or
is_check_security_for_frame or
any(argument for argument in arguments
- if argument.idl_type.name in ('ByteString', 'SerializedScriptValue') or
+ if argument.idl_type.name in ('ByteString',
+ 'ScalarValueString',
+ 'SerializedScriptValue') or
argument.idl_type.is_integer_type),
'idl_type': idl_type.base_type,
'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),
@@ -299,7 +301,8 @@ def v8_value_to_local_cpp_value(argument, index):
if argument.is_variadic:
return v8_value_to_local_cpp_variadic_value(argument, index)
# [Default=NullString]
- if (argument.is_optional and idl_type.name in ('String', 'ByteString') and
+ if (argument.is_optional and
+ idl_type.name in ('String', 'ByteString', 'ScalarValueString') and
extended_attributes.get('Default') == 'NullString'):
v8_value = 'argumentOrNull(info, %s)' % index
else:

Powered by Google App Engine
This is Rietveld 408576698